Open Bug 1652030 Opened 5 years ago Updated 1 year ago

Clean up DoH rollout prefs

Categories

(Core :: Networking: DNS, task, P3)

task

Tracking

()

People

(Reporter: nhnt11, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged])

doneFirstRun and self-enabled can be removed or at least consolidated.

skipHeuristicsCheck and disable-heuristics should be renamed.

migration code should be cleaned up.

Please adjust these severities / priorities as necessary. :-)

Severity: -- → S3
Flags: needinfo?(nhnt11)
Priority: -- → P3
Flags: needinfo?(nhnt11)
Severity: S3 → S4
Component: Security → Networking: DNS
Product: Firefox → Core
Blocks: old-prefs
No longer blocks: 1603779

Moving to [review] for clarifications of the exact instructions for each:

doneFirstRun and self-enabled can be removed or at least consolidated.
skipHeuristicsCheck and disable-heuristics should be renamed.
migration code should be cleaned up.

Flags: needinfo?(valentin.gosu)
Keywords: good-first-bug
Whiteboard: [necko-triaged][necko-priority-review]

I'm not exactly sure exactly how we need to do this, but I don't think it's a good-first-bug.

(In reply to (inactive) Nihanth Subramanya [:nhnt11] from comment #0)

doneFirstRun and self-enabled can be removed or at least consolidated.

donFirstRun can probably be removed.
https://searchfox.org/mozilla-central/search?q=FIRST_RUN_PREF&path=doh&case=false&regexp=false

Maybe self-enabled too, but this one is used in some tests to check that initialization is done.
https://searchfox.org/mozilla-central/search?q=BREADCRUMB_PREF&path=doh&case=false&regexp=false

skipHeuristicsCheck and disable-heuristics should be renamed.

I don't know what/why this is necessary

migration code should be cleaned up.

I also don't know which migration code this is referencing.

Blocks: doh-rollout
Flags: needinfo?(valentin.gosu)
Keywords: good-first-bug
Whiteboard: [necko-triaged][necko-priority-review] → [necko-triaged]
You need to log in before you can comment on or make changes to this bug.